Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added userid to review #316

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Added userid to review #316

merged 2 commits into from
Nov 9, 2023

Conversation

jesshan700
Copy link
Contributor

Added user field uid to Review

This pull request is the first step towards implementing feature Foo

  • Saves userid when submitting a review so that reviews can be associated with user.

Test Plan

Printed out data in console to ensure that user id of user submitting review is saved in data. Can see in the console that unique userId has been saved.

(Frontend testing)
Screen Shot 2023-11-08 at 12 02 41 PM

Screen Shot 2023-11-08 at 12 02 08 PM

(Backend testing)

Screen Shot 2023-11-08 at 12 18 08 PM Screen Shot 2023-11-08 at 12 17 05 PM

Can see that userId is saved in firebase with the reviews that I submitted for testing

Notes

Breaking Changes

  • Database schema change (anything that changes Firestore collection structure)
  • Other change that could cause problems (Detailed in notes)

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jesshan700
❌ jesshan70
You have signed the CLA already but the status is still pending? Let us recheck it.

@dti-github-bot
Copy link
Member

dti-github-bot commented Nov 8, 2023

[diff-counting] Significant lines: 5.

Forgot to delete console.log after testing
Copy link

github-actions bot commented Nov 8, 2023

Visit the preview URL for this PR (updated for commit 629d190):

https://cu-apts-staging--pr316-add-uid-to-review-4irg9e70.web.app

(expires Wed, 15 Nov 2023 17:33:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 096ac87b789b31770a01964fe0aaa92d563b9353

Copy link
Collaborator

@thuypham03 thuypham03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit looks clear and is able to add a new attribute (userId). This is the first step that helps retrieve users' reviews in profile page. Good job with testing thoroughly in both frontend and database log.

@jesshan700 jesshan700 merged commit 37aa2b4 into main Nov 9, 2023
6 of 7 checks passed
@jesshan700 jesshan700 deleted the add-uid-to-review branch November 9, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants