Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SEO description and pages title #317

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Add SEO description and pages title #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
086e994
add web description and pages title
Nov 9, 2023
3c9d790
change title
Nov 9, 2023
02d15c6
Merge branch 'main' into seo
thuypham03 Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion frontend/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
<meta name="msapplication-config" content="%PUBLIC_URL%/browserconfig.xml" />
<meta name="theme-color" content="#ffffff" />
<meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1" />
<meta name="keywords" content="cornell apartments, apartments at cornell, etc" />
<meta name="description" content="Cornell Apartments Finder for Off-campus Housing" />
<!-- Fonts -->
<link rel="preconnect" href="https://fonts.gstatic.com" />
<link
Expand All @@ -31,7 +33,7 @@
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
<title>CUAPTS</title>
<title>CUAPTS - Cornell's Off-campus Housing Finder</title>
</head>

<body>
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/pages/AdminPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Typography, makeStyles, Grid, Container } from '@material-ui/core';
import { ReviewWithId } from '../../../common/types/db-types';
import { get } from '../utils/call';
import AdminReviewComponent from '../components/Admin/AdminReview';
import { useTitle } from '../utils';

const useStyles = makeStyles((theme) => ({
container: {
Expand All @@ -24,6 +25,8 @@ const AdminPage = (): ReactElement => {

const { container } = useStyles();

useTitle('Admin');

// calls the APIs and the callback function to set the reviews for each review type
useEffect(() => {
const reviewTypes = new Map<string, React.Dispatch<React.SetStateAction<ReviewWithId[]>>>([
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/pages/HomePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import ApartmentCards from '../components/ApartmentCard/ApartmentCards';
import { CardData } from '../App';
import { get } from '../utils/call';
import { loadingLength } from '../constants/HomeConsts';
import { useTitle } from '../utils';

const useStyles = makeStyles({
jumboText: {
Expand Down Expand Up @@ -40,6 +41,8 @@ const HomePage = (): ReactElement => {
const [isMobile, setIsMobile] = useState<boolean>(false);
const [drawerOpen] = useState<boolean>(false);

useTitle('Home');

useEffect(() => {
get<returnData>(`/api/page-data/home/${loadingLength}`, {
callback: setData,
Expand Down
4 changes: 4 additions & 0 deletions frontend/src/pages/Policies.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React, { ReactElement } from 'react';
import { Container, Link, Typography, makeStyles } from '@material-ui/core';
import { colors } from '../colors';
import { useTitle } from '../utils';

const useStyles = makeStyles(() => ({
h2: {
Expand Down Expand Up @@ -42,6 +43,9 @@ const useStyles = makeStyles(() => ({

const Policies = (): ReactElement => {
const { h2, h3, h4, body, link } = useStyles();

useTitle('Policies');

return (
<Container maxWidth="lg">
<Typography variant="h2" className={h2}>
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/pages/ProfilePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { colors } from '../colors';
import questionIcon from '../assets/question.svg';
import { signOut } from '../utils/firebase';
import { useHistory } from 'react-router-dom';
import { useTitle } from '../utils';

type Props = {
user: firebase.User | null;
Expand Down Expand Up @@ -144,6 +145,8 @@ const ProfilePage = ({ user, setUser }: Props): ReactElement => {
const theme = useTheme();
const isXsScreen = useMediaQuery(theme.breakpoints.down('xs'));

useTitle('Profile');

/** This function opens the 'Who can view my profile?' modal **/
const openModal = () => {
setIsModalOpen(true);
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/pages/SearchResultsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { get } from '../utils/call';
import { colors } from '../colors';
import { CardData } from '../App';
import ApartmentCards from '../components/ApartmentCard/ApartmentCards';
import { useTitle } from '../utils';

const useStyles = makeStyles({
searchText: {
Expand All @@ -20,6 +21,8 @@ const SearchResultsPage = (): ReactElement => {
const query = location.search.substring(3);
const isMobile = useMediaQuery('(max-width:600px)');

useTitle('Search Result');

useEffect(() => {
get<CardData[]>(`/api/search-results?q=${query}`, {
callback: setSearchResults,
Expand Down
Loading