-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add review photo carousel functionality #375
Conversation
- Refactor the PhotoCarousel component to update the styling to handle large photos. - Add functionality to the PhotoCarousel component to display a carousel with a different start index - The PhotoCarousel component now accepts a start index as a prop. - Clicking on a photo in the Review and AdminReview components triggers the photo carousel with the corresponding photos and start index.
[diff-counting] Significant lines: 262. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Review
The refactoring of the component performs greatly and it is well handled across multiple different file/page locations. Some suggestions:
- The line of dot circles below the photo carousel is a great indication of the display progress. Currently the circles will follow the height of the image thus have some vertical translations. This situation is more visible for photos of significant size differences.
- The modal carousel's interaction pattern could be refined - currently, users need to move their cursor beyond the navigation arrows to exit the view. While this prevents accidental closures, it may not align with common user expectations, where clicking any area outside the main image content typically dismisses a modal. Consider adjusting the active zone to create a more fluid browsing experience.
PR Changes
Notes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is super useful so users can see pictures in bigger resolutions. Thanks for coordinating with designers to get their response!
Summary
The photo previews in reviews are small, making it difficult to check if a photo is appropriate as an admin and difficult for users to view. This pull request extends the usage of the PhotoCarousel component to support review photo previews and different starting indexes.
Test Plan
I tested the review pop up on all pages with review components or admin review components, including AdminPage, ApartmentPage, BookmarksPage, LandlordPage, ProfilePage. I tested it on large vertical and horizontal photos to make sure buttons remain on the screen. I also tested responsiveness across mobile and desktop devices. I also tested the photo carousel still works on previewing apartment photos to ensure backward compatibility.
Desktop
Mobile
Desktop
Mobile
Notes