[Ready for Review] Fix Helpful Reviews #377
Conversation
- supports optional query parameter to filter by status - by default it will not filter by status - add documentation for review/like/:userId
- simplified update process - removed useState for reviewData so changes to originally passed prop review will update on the component. - added helpful icon - ensure color of icon updated when liked
- adds query term for APPROVED - delete from the list locally when it is disliked
- update pending reviews locally when like changes
|
[diff-counting] Significant lines: 249. |
kea-roy
changed the title
There was a problem hiding this comment.
The like/helpful review functionality is robust and works well on each page.
I like the implementation of the design which makes the functionality more intuitive.
There is an edge case in the /api/review/like/:userId endpoint where a user with an existing likes document but no actual likes (so empty document) will trigger a Firestore error:
Error: Invalid Query. A non-empty array is required for 'in' filters.
Suggested fix is adding to backend/src/app.ts:184-187:
if (reviewIds.length === 0) { res.status(200).send(JSON.stringify([])); return; }
This fix handles the empty like situation by returning an empty array, which is the same behavior as if the user does not have an existing document.
kea-roy
dismissed
CasperL1218’s stale review
I have resolved and fixed the issue
Summary
This pull request resolves front-end and back-end issues with marking reviews as helpful. The most important changes include updating the backend API endpoint for fetching liked reviews, adding a new icon for helpful reviews on the frontend, and refactoring the frontend components to handle review data more efficiently.
Checklist
Changes
Backend Changes:
backend/src/app.ts)Frontend Changes:
Review Component Enhancements:
HelpfulIconfor displaying the helpfulness of reviews. (frontend/src/components/Review/Review.tsx) [1] [2] [3]ReviewComponentto directly use thereviewprop instead of maintaining a separate state forreviewData. (frontend/src/components/Review/Review.tsx) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Page Component Updates:
frontend/src/pages/ApartmentPage.tsx) [1] (frontend/src/pages/BookmarksPage.tsx) [2] [3] [4] (frontend/src/pages/LandlordPage.tsx) [5] (frontend/src/pages/ProfilePage.tsx) [6]Test Plan
Tested using Postman and end-to-end user testing. I tested the API endpoint to ensure it returns correctly and is called correctly on all pages. I tried testing while logged in and while not logged in, liking it before and after, and spam clicking.
(Not marked helpful)
(Marked helpful)
Notes