[Ready for Review] Fix report abuse #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add report validation - Update review status endpoint - Prevent reporting of pending reviews and own reviews
- Add report confirmation modal - Add report button logic - Prevent reporting of own reviews
- Show reported reviews in apartment page - Add reported reviews section to profile page - Add success toast notifications
|
[diff-counting] Significant lines: 424. |
kea-roy
requested changes
Nov 20, 2024
There was a problem hiding this comment.
PR Review
You implemented the report abuse confirmation modal really well with no flaws, and the toast works correctly as expected. Good work on these parts.
You also adjusted the app.ts really well, I love the security checks and the logic works correctly.
I like the addition of the collapsing arrows and it really helps improve the user experience! One minor change would be to switch the open and close state direction to match the convention across our site, so just flip the rotate CSS.
This is the current state, but it should be the opposite.
kea-roy
previously approved these changes
Dec 3, 2024
ggsawatyanon
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Here are a few changes I'd like to request:
- Change the admin button wording from "Approve" to "Ignore" for clarity
- The report abuse button should be visible when the user isn't signed in. If they aren't signed in, it should prompt them to sign in. (Same as the helpful review button)
- Don't send users email of approved reviews when the report has been ignored.
- Updated AdminReview component to allow decline, delete, approve, ignore button toggles - Updated AdminPage reported reviews to display delete and ignore button options - Modfied update-review-status endpoint to prevent sending email from ignoring a reported review (status from " REPORTED" --> "APPROVED")
ggsawatyanon
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request enhanced the Report Abuse feature for reviews. The new Report Abuse feature provides a more comprehensive process for reporting reviews, and allowing admin to monitor reported reviews to take actions.
Main Requirements Completed:
Backend Changes Completed:
date,reason, anduserIdreasonfield will require future frontend processREPORTEDreview statusFrontend Changes Completed:
APPROVEDandREPORTEDreviews)Review Status Flow Fixed:
Edge Cases Handled:
Test Plan
*Reported reviews in profile page: 1. Reported reviews can't be edited/deleted. 2. Can't report self's reviews.
*Only able to report other users' review. REPORTED reviews are still visible.
*Admin page reported review display
*Admin page review section dropdown menu
Test the following flows:
Regular user flow:
Edge cases:
Notes
Breaking Changes
reportsarray field to review documents (lazy migration)Future Plans