Fixed UI Bugs for QMI Wrapped #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgu0114
reviewed
Dec 19, 2024
src/components/includes/Wrapped.tsx
Outdated
| className="visit bottom-text" | ||
| > | ||
| <Typography variant="h3"> | ||
| <div className="visit num-visits"> {wrappedData.officeHourVisits.length} </div> |
There was a problem hiding this comment.
oh wait we're using numVisits instead of officeHourVisits`, I think we might've only deployed this on release branch but master isn't up to date lemme check
|
[diff-counting] Significant lines: 31. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since the launch of QMI Wrapped, there were some minor UI bugs that needs to be addressed:
Most of the changes in this PR are CSS changes made in
Wrapped.scssTest Plan
Tested via local server
Keep Wrapped Notification on top of the notif banner
Fix font size and weight consistency
Screen.Recording.2024-12-08.at.7.48.40.PM.mov
Notes
Breaking Changes
None