-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup] Bump dependency version and fix new linter errors #267
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,12 +17,17 @@ | |
"ExportDeclaration": { "minProperties": 10, "multiline": true, "consistent": true } | ||
} | ||
], | ||
"react/prop-types": "off", | ||
"react/jsx-props-no-spreading": "warn", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it may become harmful in the future due to this React commit and we eventually want to fix it. Therefore, I change the level to warning. |
||
"react/jsx-filename-extension": ["error", { "extensions": [".jsx", ".tsx"] }], | ||
"import/extensions": [".js", ".mjs", ".jsx", ".ts", ".tsx"], | ||
"react/state-in-constructor": "off", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It doesn't work well with class A extends React.Component {
state = { foo: 'bar' };
} |
||
"import/extensions": "off", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It doesn't like json extension |
||
"indent": "off", | ||
"@typescript-eslint/ban-ts-ignore": "warn", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's better to have warnings so we can fix it eventually. |
||
"@typescript-eslint/indent": ["error", 2], | ||
"@typescript-eslint/prefer-interface": "off", | ||
"@typescript-eslint/explicit-function-return-type": ["error", { "allowExpressions": true }], | ||
"@typescript-eslint/no-angle-bracket-type-assertion": "off", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deprecated in @typescript-eslint v2. Have to keep it and set to off since create-react-app still uses V1. There is a pull request that tries to fix it: facebook/create-react-app#7540 |
||
"@typescript-eslint/no-unused-vars": [ | ||
"error", | ||
{ "vars": "all", "args": "after-used", "ignoreRestSiblings": true } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have TS. This is unnecessary