Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mean_cache data extraction for dKG #2452

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

yyexela
Copy link
Contributor

@yyexela yyexela commented Dec 4, 2023

Issue: dKG in BoTorch no longer works since I last ran it a few months ago. It appears to be from the mean_cache going from size [num_fantasies, 1, 1, num_data] to [num_fantasies, num_fantasies, num_fantasies, num_data]. What this change does is extract the relevant data of mean_cache while keeping the expected shape for the rest of the code (ie. [num_fantasies, 1, num_data]).

Not sure about a unit test for this since it depends on having BoTorch's qKnowledgeGradient class, among other dependencies.

See pytorch/botorch#2137

@yyexela
Copy link
Contributor Author

yyexela commented Dec 4, 2023

Any idea why the unit test is failing when there is no code change?

@yyexela
Copy link
Contributor Author

yyexela commented Dec 4, 2023

Noticed main fails the same test so I'm assuming my code works and it's another problem.

EDIT: Unit tests aren't passing but neither are the ones in main, so I'll assume this change is what's needed for now.

yyexela referenced this pull request in yyexela/botorch Jan 19, 2024
@CedricTravelletti
Copy link

Any news on this PR? I confirm that there is interest in gradient-enabled GPs/BO for several application cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants