Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Segmentation state restructure to add main representation #19

Merged
merged 20 commits into from
Mar 28, 2022
Merged

feat: Segmentation state restructure to add main representation #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
e9e7b4f
initial state change
sedghi Mar 25, 2022
40f52dd
change getToolGroupByToolGroupId to getToolGroupById
sedghi Mar 25, 2022
eb44e9c
renamed segmentation state types
sedghi Mar 25, 2022
865852a
add segmentation to global
sedghi Mar 25, 2022
d785a9c
rename segmentationUID to segmentationId
sedghi Mar 25, 2022
5b11cc1
add segmentation to state completed
sedghi Mar 25, 2022
db1519b
wip for labelmap add segmentaiton representation
sedghi Mar 25, 2022
798a732
initial rendering for segmentation representations
sedghi Mar 25, 2022
0f7a052
make rectangle scissor work
sedghi Mar 25, 2022
48f619a
make all scissors work
sedghi Mar 25, 2022
20514bc
wip for segmentation controllers
sedghi Mar 25, 2022
b68595c
fix active segmentation selection
sedghi Mar 25, 2022
7797054
fix segmentation representation remove
sedghi Mar 25, 2022
2d7674b
make segment locking work
sedghi Mar 25, 2022
17dd396
make create new segmentation work
sedghi Mar 25, 2022
1980c24
make global segmentation config work
sedghi Mar 26, 2022
8cced42
make the representation config work
sedghi Mar 26, 2022
0c41633
fix segmentatoin tests
sedghi Mar 26, 2022
dd85d13
fix tests and build errors
sedghi Mar 26, 2022
54d679d
address review comments
sedghi Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions common/reviews/api/core.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ type CPUImageData = {
};

// @public (undocumented)
function createAndCacheDerivedVolume(referenceVolumeId: string, options: DerivedVolumeOptions): ImageVolume;
function createAndCacheDerivedVolume(referencedVolumeId: string, options: DerivedVolumeOptions): ImageVolume;

// @public (undocumented)
function createAndCacheVolume(volumeId: string, options: VolumeLoaderOptions): Promise<Record<string, any>>;
Expand Down Expand Up @@ -830,7 +830,7 @@ interface IImageVolume {
// (undocumented)
origin: Point3;
// (undocumented)
referenceVolumeId?: string;
referencedVolumeId?: string;
// (undocumented)
scalarData: any;
// (undocumented)
Expand Down Expand Up @@ -987,7 +987,7 @@ export class ImageVolume implements IImageVolume {
// (undocumented)
origin: Point3;
// (undocumented)
referenceVolumeId?: string;
referencedVolumeId?: string;
// (undocumented)
scalarData: Float32Array | Uint8Array;
// (undocumented)
Expand Down Expand Up @@ -1251,7 +1251,7 @@ interface IVolume {
// (undocumented)
origin: Point3;
// (undocumented)
referenceVolumeId?: string;
referencedVolumeId?: string;
// (undocumented)
scalarData: Float32Array | Uint8Array;
// (undocumented)
Expand Down
4 changes: 2 additions & 2 deletions common/reviews/api/streaming-image-volume-loader.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ interface IImageVolume {
metadata: Metadata
numVoxels: number
origin: Point3
referenceVolumeId?: string
referencedVolumeId?: string
scalarData: any
scaling?: {
PET?: {
Expand Down Expand Up @@ -818,7 +818,7 @@ interface IVolume {
imageData?: vtkImageData
metadata: Metadata
origin: Point3
referenceVolumeId?: string
referencedVolumeId?: string
scalarData: Float32Array | Uint8Array
scaling?: {
PET?: {
Expand Down
Loading