playClip works better when timer fires slowly #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1519 +/- ##
==========================================
- Coverage 21.70% 21.69% -0.01%
==========================================
Files 287 287
Lines 10137 10141 +4
Branches 2081 2081
==========================================
Hits 2200 2200
- Misses 6750 6754 +4
Partials 1187 1187 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video Demo
https://youtu.be/C6jsGZfL82s
Description
This change makes playClip playback keep real time by dropping missed frames if the computer cannot keep up with the requested framerate. Without this change, providers perceive playback to "slow down." With this change, the playback is always kept to "real time" at the expense of dropping frames that must be skipped.