Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox unknow address #12

Closed
Novite5 opened this issue Jan 26, 2019 · 7 comments
Closed

Firefox unknow address #12

Novite5 opened this issue Jan 26, 2019 · 7 comments

Comments

@Novite5
Copy link

Novite5 commented Jan 26, 2019

After scoring the answer, Ankitab will jump to address:

chrome-search://local-ntp/local-ntp.html

which cannot be recognized by Firefox.

Thank you for your work!

@corollari
Copy link
Owner

Given that you mention that this happens after scoring an answer, it seems you could be using the feature requested in #7. Are you loading the extension unpacked from the answer-redirect branch?

@Novite5
Copy link
Author

Novite5 commented Jan 27, 2019

No. I get the addon from Mozilla official store.

@Novite5
Copy link
Author

Novite5 commented Jan 27, 2019

19:00:46.294 Error: Could not establish connection. Receiving end does not exist. Browser.js:3:1937 19:00:47.473 Error: Could not establish connection. Receiving end does not exist. Browser.js:3:1937 19:01:10.779 'NoneType' object has no attribute 'hide' ankiConnect.js:22:17 ankiConnectInvoke/</< moz-extension://e22a492a-4b7b-4a3a-b37d-9e3e9cf39d8a/libs/ankiConnect.js:22:17 19:01:11.471 TypeError: docShell.failedChannel is null[Learn More] NetErrorChild.jsm:683:13 19:01:11.693 Error: Could not establish connection. Receiving end does not exist. Browser.js:3:1937 19:02:06.404 NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIInterfaceRequestor.getInterface] network-response-listener.js:73

this is the error log in web console.

@corollari
Copy link
Owner

I see, then the redirection seems to be caused by the following code:

ankiConnectInvoke("guiDeckReview", {name: lastDeck})
						.then(()=>chrome.storage.local.set({lastDeck: lastDeck}, resolve))
						.catch((e)=>{
							window.location.href="chrome-search://local-ntp/local-ntp.html"
						});

I've been able to reproduce the bug, I'll start working on a fix.

corollari added a commit that referenced this issue Jan 27, 2019
@corollari
Copy link
Owner

Just fixed it! 🎉
Thanks for reporting it :)

@corollari
Copy link
Owner

Just published the updated extension, it should be available after the review passes (~a few hours).

@Novite5
Copy link
Author

Novite5 commented Jan 28, 2019

Great! It works.
Thank you very much!

@Novite5 Novite5 closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants