Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cymbal choke causes rim triggers #111

Open
3hhh opened this issue Nov 6, 2023 · 6 comments
Open

cymbal choke causes rim triggers #111

3hhh opened this issue Nov 6, 2023 · 6 comments

Comments

@3hhh
Copy link
Contributor

3hhh commented Nov 6, 2023

Using the cymbal choke currently causes low volume rim triggers (usually two or so).

Also, holding the choke sometimes seems to just delay playback rather than stopping it. The latter may be a drumgizmo issue though.

@corrados
Copy link
Owner

corrados commented Nov 7, 2023

Yes, this is true. I can see this with my Roland cymbal as well. But it is not noticeable during my normal playing.

The choke detection in Edrumulus is delayed a bit. Therefore, you will have a similar issue like you had with the cross-talk cancellation. The invalid detected strike will be there before the choke is detected.

Maybe you could try to suppress these MIDI notes with your Python script like you do with the cross-talk cancellation. Would be interesting to know if that works.

@corrados
Copy link
Owner

corrados commented Nov 7, 2023

I just tested this with my Roland TD-27 and the Roland cymbal pad and I sometimes see exactly the same behavior as in Edrumulus, i.e., a Note On with MIDI note 49 is output on pressing the pad (choking it):
grafik

@3hhh
Copy link
Contributor Author

3hhh commented Nov 7, 2023 via email

@corrados
Copy link
Owner

corrados commented Nov 7, 2023

Would be interesting to know how your Millenium brain performs in this situation. Do you see similar effects?

@3hhh
Copy link
Contributor Author

3hhh commented Nov 11, 2023

This could partially be fixed via my script. Only partially as the first incorrect MIDI event happens ~10ms before the choke, the second ~5ms and I only want to delay events by at most 5ms, i.e. the first will continue to pass. In theory 10ms delay is supported though.

@3hhh
Copy link
Contributor Author

3hhh commented Jan 5, 2024

Btw increasing the sense time helped with this issue. However it caused worse rim detection, so that I dropped the change again.

3hhh added a commit to 3hhh/xtalk that referenced this issue May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants