Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge forward prototype thijstriemstra #114

Closed

Conversation

thijstriemstra
Copy link
Contributor

@thijstriemstra thijstriemstra commented Nov 8, 2023

I want to update my prototype to latest version (I was using year old code) so merging it forward. I'm commenting out the customizations I made and starting fresh with new code.

If you see any mistakes in this config, please let me know @corrados

corrados and others added 30 commits December 20, 2021 19:33
@thijstriemstra thijstriemstra marked this pull request as ready for review November 8, 2023 14:21
@corrados
Copy link
Owner

corrados commented Nov 8, 2023

I am using Edrumulus only by using the run_edrumulus script. Therefore, always the edrumulus_gui is used when I use Edrumulus. The advantage of this is that edrumulus_gui takes care of all the settings so that you do not have to modify anything in the preset_settings() function.

If you always use edrumulus_gui as well, the only thing you have to adjust are the analog_pin settings and the number_pads value.

@thijstriemstra
Copy link
Contributor Author

If you always use edrumulus_gui as well, the only thing you have to adjust are the analog_pin settings and the number_pads value.

Thanks, I'll do that from now on.

@corrados
Copy link
Owner

I assume that you do not want me to merge your custom prototype branch to main, right? At least it does not make sense for me because it is specific to your prototype and should stay on a branch.

@thijstriemstra
Copy link
Contributor Author

At least it does not make sense for me because it is specific to your prototype and should stay on a branch.

True, sorry for the confusion, I wanted some feedback on my changes but this was probably wrong way to do it hehe. Thanks for the feedback though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants