Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPS 750x #89

Merged
merged 1 commit into from
Nov 16, 2023
Merged

MPS 750x #89

merged 1 commit into from
Nov 16, 2023

Conversation

3hhh
Copy link
Contributor

@3hhh 3hhh commented Aug 18, 2023

Some test files as discussed.

@3hhh 3hhh changed the title MPS 750x Tom signals added Draft: MPS 750x Tom signals added Aug 18, 2023
@3hhh 3hhh marked this pull request as draft August 18, 2023 14:43
@3hhh 3hhh changed the title Draft: MPS 750x Tom signals added MPS 750x Tom signals added Aug 18, 2023
@3hhh 3hhh changed the title MPS 750x Tom signals added MPS 750x Aug 18, 2023
@3hhh 3hhh marked this pull request as ready for review November 7, 2023 21:47
@3hhh
Copy link
Contributor Author

3hhh commented Nov 7, 2023

This should be ready now.

edrumulus_parameters.cpp Outdated Show resolved Hide resolved
3hhh added a commit to 3hhh/edrumulus that referenced this pull request Nov 11, 2023
edrumulus.ino Outdated Show resolved Hide resolved
edrumulus_parameters.cpp Outdated Show resolved Hide resolved
tools/edrumulus_gui.py Outdated Show resolved Hide resolved
@3hhh
Copy link
Contributor Author

3hhh commented Nov 14, 2023 via email

@corrados
Copy link
Owner

Hm, you could try to change the following line:

rim_switch_treshold = -pow ( 10.0f, pad_settings.rim_shot_treshold / 10.0f ); // rim switch linear threshold, where 10^(31/10)=1259 which is approx 4096/3 (10 bit ADC)

and introduce some offset:

rim_switch_treshold = -pow ( 10.0f, ( pad_settings.rim_shot_treshold - 15 ) / 10.0f );

which is introducing an offset of 15. If that is not enough, simply increase that offset until you are in range.

@corrados
Copy link
Owner

Sorry, you have to add the offset, not subtract it:

rim_switch_treshold = -pow ( 10.0f, ( pad_settings.rim_shot_treshold + 15 ) / 10.0f );

@3hhh
Copy link
Contributor Author

3hhh commented Nov 14, 2023 via email

@corrados
Copy link
Owner

the average voltage seen during the switching/"DC offset" should be slightly different for the different input impedances (edge vs bell). Possibly one could detect that.

That's exactly what I would like to find out. And I hope we can do that by simply introducing a second threshold. But first we (i.e. actually you :-) ) have to find out if it works by changing the one threshold we currently have available to see if it could work.

tools/edrumulus_gui.py Outdated Show resolved Hide resolved
edrumulus_parameters.cpp Outdated Show resolved Hide resolved
@corrados
Copy link
Owner

Thanks, I'll merge it now.

@corrados corrados merged commit 6634d25 into corrados:main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants