Fix hostbuild with clang #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Double negation is always harder to think about, so add a variable hostbuild_override which can be used in places where we previously did double negation. Also change around the `IF` ordering in some cases to remove the negation in the argument.
Fixes a case where a target which should be built for the host platform , erroneously got a linker flag instructing clang to link for the cross-compile target.
jschwe
added a commit
to jschwe/corrosion
that referenced
this pull request
Jun 22, 2023
Test cross-compiling with clang. This should catch the issue fixed in corrosion-rs#338. Closes corrosion-rs#339.
jschwe
added a commit
to jschwe/corrosion
that referenced
this pull request
Jun 23, 2023
Test cross-compiling with clang. This should catch the issue fixed in corrosion-rs#338. Closes corrosion-rs#339.
jschwe
added a commit
to jschwe/corrosion
that referenced
this pull request
Jul 30, 2023
Test cross-compiling with clang. This should catch the issue fixed in corrosion-rs#338. Closes corrosion-rs#339.
jschwe
added a commit
to jschwe/corrosion
that referenced
this pull request
Aug 5, 2023
Test cross-compiling with clang. This should catch the issue fixed in corrosion-rs#338. Closes corrosion-rs#339.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a case where a target which should be built for the host platform, erroneously got a linker flag instructing clang to link for the cross-compile target.