-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Propagate rustc native-static-libs to CMake #472
Draft
jschwe
wants to merge
17
commits into
corrosion-rs:master
Choose a base branch
from
jschwe:dynamic_link_libs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 5, 2024
-
Propagate rustc native-static-libs to CMake
CMake usually requires all libraries required for linking to be specified at CMake configure time. However, in Rust native dependencies may be specified inside the source code via the [`link`] attribute. `rustc` can be instructed to print all required native libraries at build time, however this is already after the CMake configure stage has finished. To work around this we wrap the build command for Rust static libraries in a wrapper script, that parses the required libraries from the `rustc` output and writes them into an `rsp` file. At configure time we can then instruct CMake to read the linker arguments from the file that our wrapper will generate later at build time. [`link`]: https://doc.rust-lang.org/reference/items/external-blocks.html#the-link-attribute
Configuration menu - View commit details
-
Copy full SHA for 4c8ebb4 - Browse repository at this point
Copy the full SHA 4c8ebb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5392e5a - Browse repository at this point
Copy the full SHA 5392e5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e02c27 - Browse repository at this point
Copy the full SHA 5e02c27View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7f1bc9 - Browse repository at this point
Copy the full SHA e7f1bc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96f210f - Browse repository at this point
Copy the full SHA 96f210fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b2c789 - Browse repository at this point
Copy the full SHA 4b2c789View commit details -
Configuration menu - View commit details
-
Copy full SHA for d784810 - Browse repository at this point
Copy the full SHA d784810View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28c49da - Browse repository at this point
Copy the full SHA 28c49daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54d8e99 - Browse repository at this point
Copy the full SHA 54d8e99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 275dc81 - Browse repository at this point
Copy the full SHA 275dc81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5268f88 - Browse repository at this point
Copy the full SHA 5268f88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7103869 - Browse repository at this point
Copy the full SHA 7103869View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a22ba2 - Browse repository at this point
Copy the full SHA 0a22ba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90b9149 - Browse repository at this point
Copy the full SHA 90b9149View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a2758a - Browse repository at this point
Copy the full SHA 0a2758aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9061782 - Browse repository at this point
Copy the full SHA 9061782View commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0cbe37f - Browse repository at this point
Copy the full SHA 0cbe37fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.