-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add lock kwarg to to_raster and add examples of using dask for file io #223
Conversation
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 93.17% 92.13% -1.04%
==========================================
Files 11 11
Lines 1260 1259 -1
==========================================
- Hits 1174 1160 -14
- Misses 86 99 +13
Continue to review full report at Codecov.
|
I just found out that this exists and could maybe simplify this: I found that some of the dask functions actually use this and default to it. |
Isn't that how this |
For GeoTiff you need the global lock or you get the problems you found in #220 |
So "global" as in the global scope of the calling module, right? Couldn't users use this utility function so they don't have to decide what lock to choose? |
It means that the lock needs to be shared by all processes and threads.
I don't think so. Based on the dask issues I have seen, the SerializableLock only locks the threads within the process that contains. And the multiprocessing lock doesn't work for a cluster of machines. So, the dask Lock is the only option. But, I recommend trying it out and seeing what happens. You should be able to try it out now and see if it works or not. |
docs/history.rst
for all changes anddocs/rioxarray.rst
for new APIcc: @djhoese