Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockless multi-threaded reads #224

Merged
merged 7 commits into from
Jan 28, 2021
Merged

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Jan 28, 2021

@TomAugspurger
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #224 (ec80e6c) into master (97c0d4f) will increase coverage by 0.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   92.13%   92.15%   +0.01%     
==========================================
  Files          11       11              
  Lines        1259     1287      +28     
==========================================
+ Hits         1160     1186      +26     
- Misses         99      101       +2     
Impacted Files Coverage Δ
rioxarray/_io.py 87.50% <93.33%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c0d4f...76abd3f. Read the comment docs.

Tom Augspurger added 2 commits January 28, 2021 09:12
@snowman2
Copy link
Member

This is really nice 👍. I like that there are different options available for the file manager.

@snowman2 snowman2 requested a review from justingruca January 28, 2021 16:26
Copy link

@justingruca justingruca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple text changes.

docs/history.rst Outdated Show resolved Hide resolved
docs/examples/read-locks.ipynb Outdated Show resolved Hide resolved
@TomAugspurger
Copy link
Contributor Author

Whoops, thanks. Fixed those typos.

@snowman2
Copy link
Member

@TomAugspurger would you like to squash your commits or do you mind if I do a squash and merge?

@TomAugspurger
Copy link
Contributor Author

Squash and merge is fine by me.

@snowman2 snowman2 merged commit f867353 into corteva:master Jan 28, 2021
@snowman2
Copy link
Member

Thanks @TomAugspurger 👍

@TomAugspurger
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with locking when reading from multiple threads with Dask
3 participants