CI: add test for building sdist and wheel packages #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowman2
reviewed
Jun 18, 2022
| - name: Check packages | ||
| shell: bash | ||
| run: | | ||
| twine check dist/* |
There was a problem hiding this comment.
Do you think that the --strict flag would add any value here?
There was a problem hiding this comment.
yes, planning to enable it after #534, otherwise the current warnings will fail the workflow.
|
This will be nice to have, thanks 👍 |
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 13 13
Lines 1591 1591
=======================================
Hits 1531 1531
Misses 60 60 Continue to review full report at Codecov.
|
|
Thanks @mwtoews 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CI workflow essentially checks
python -m buildto see if it builds sdist and wheel packages.