write to raster using windowed writing & add isel_window method #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst
for all changes andapi.rst
for new APIThe thing that I am on the fence about is if we want to make windowed writing the default or the previous behavior the default. The windowed writing can be more memory efficient, but may not be as fast reading the entire chunk into memory. There are different scenarios. So, maybe add a
windowed=True
kwarg to turn on/off this behavior.Side note: since the block sizes of the destination raster are created with rasterio, it should be constant across all bands, so that isn't something to worry about.