Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix closing files manually #607

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Nov 11, 2022

In #606 it became evident that the files were not being closed. This fix should help users to close Datasets that have data_vars pointing to files.

@snowman2 snowman2 added this to the 0.13.1 milestone Nov 11, 2022
@snowman2 snowman2 force-pushed the close_files branch 2 times, most recently from adb8d3b to 58451e4 Compare November 11, 2022 18:41
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 96.33% // Head: 96.37% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (a85545d) compared to base (49f2815).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
+ Coverage   96.33%   96.37%   +0.04%     
==========================================
  Files          11       11              
  Lines        1691     1711      +20     
==========================================
+ Hits         1629     1649      +20     
  Misses         62       62              
Impacted Files Coverage Δ
rioxarray/_io.py 96.55% <100.00%> (+0.10%) ⬆️
rioxarray/xarray_plugin.py 92.59% <100.00%> (+1.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@snowman2
Copy link
Member Author

Thanks @justingruca 👍

@snowman2 snowman2 merged commit c7a5150 into corteva:master Nov 11, 2022
@snowman2 snowman2 deleted the close_files branch November 11, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants