Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust handling of GCPs geojson #731 #735

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

Kirill888
Copy link
Contributor

  • when gcp.z==None, don't write z coord to geojson

- when `gcp.z==None`, don't write z coord to geojson
@snowman2 snowman2 added the bug Something isn't working label Jan 18, 2024
@snowman2 snowman2 added this to the 0.15.1 milestone Jan 18, 2024
@snowman2
Copy link
Member

Looks good to me. cc: @mraspaud in case you wanted to take a look.

Copy link
Member

@snowman2 snowman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kirill888 👍

rioxarray/rioxarray.py Outdated Show resolved Hide resolved
rioxarray/rioxarray.py Outdated Show resolved Hide resolved
rioxarray/rioxarray.py Outdated Show resolved Hide resolved
Co-authored-by: Alan D. Snow <alansnow21@gmail.com>
@snowman2 snowman2 merged commit a8b2f41 into corteva:master Jan 23, 2024
18 of 19 checks passed
@Kirill888 Kirill888 deleted the fix-731 branch January 23, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GCPs without known z coordinate
2 participants