Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix minor code block issue for local installation in CONTRIBUTING.rst #792

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

dluks
Copy link
Contributor

@dluks dluks commented Jul 3, 2024

Fixes a typo which caused code block rendering to fail. Also adds quotes around .[all] as pip install -e .[all] fails in some environments. E.g.:

$ python -m pip install -e .[all]
zsh: no matches found: .[all]

$ python -m pip install -e ".[all]"
... # (works)
  • Fully documented, including docs/history.rst for all changes and docs/rioxarray.rst for new API

☝️ I didn't add anything to docs/history.rst as it doesn't appear to be the convention when updating documentation.

…ng doc

Fixes a typo which caused code block rendering to fail. Also adds quotes around ".[all]" as only `pip install -e .[all]` fails in some environments.
@snowman2 snowman2 added the documentation Documentation related issue label Jul 3, 2024
@snowman2
Copy link
Member

snowman2 commented Jul 3, 2024

Thanks @dluks 👍

@snowman2 snowman2 merged commit 85290b1 into corteva:master Jul 3, 2024
17 of 19 checks passed
@dluks dluks deleted the docs/fix-contribution-instructions branch July 4, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants