Add podManagementPolicy to store gateway statefulset template #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschad
requested changes
Mar 10, 2022
mehta-ankit
force-pushed
the
podmanagement-policy
branch
from
3efcfd7 to
a67be83
Compare
|
@nschad thanks for the review. Made the changes as requested. |
mehta-ankit
force-pushed
the
podmanagement-policy
branch
2 times, most recently
from
59daeff to
be04c74
Compare
|
Don't write the README.md yourself. Have helm-docs generate it for you automatically. I can do that tomorrow for you if you want. |
mehta-ankit
force-pushed
the
podmanagement-policy
branch
from
be04c74 to
7b90b91
Compare
Ohh my bad 🤦🏽♂️ I did not understand your earlier comment properly. Used helm-docs to generate it now. Hopefully it ll all be good 🤞🏽 😅 |
nschad
approved these changes
Mar 11, 2022
kd7lxl
reviewed
Mar 11, 2022
kd7lxl
reviewed
Mar 11, 2022
mehta-ankit
force-pushed
the
podmanagement-policy
branch
2 times, most recently
from
5301d68 to
3029dac
Compare
Signed-off-by: Ankit Mehta <ankit.mehta@appian.com>
mehta-ankit
force-pushed
the
podmanagement-policy
branch
from
3029dac to
b32e7db
Compare
|
@kd7lxl This should be ready to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ankit Mehta ankit.mehta@appian.com
What this PR does:
Allows one to set PodManagementPolicy on store-gateway Satefulset same as how we can do that for Ingesters in this helm chart.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]