Use flagext package from cortexproject #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the dependency on grafana/dskit since it was only used for its flagext package. Fixes: cortexproject#23 Signed-off-by: Charlie Le <charlie_le@apple.com>
|
Seems the lint is failing for some other reason. Should we merge this and fix the lint in another PR, @friedrichg ? |
|
Yes |
|
@alanprot @friedrichg fix for lint: #26 |
friedrichg
pushed a commit
that referenced
this pull request
May 9, 2024
This also removes the dependency on grafana/dskit since it was only used for its flagext package. Fixes: #23 Signed-off-by: Charlie Le <charlie_le@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the dependency on several other packages in github.com/grafana/dskit.
Fixes: #23
Signed-off-by: Charlie Le charlie_le@apple.com