Upgrade Go version to 1.22 in go.mod and workflows #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieTLe
force-pushed
the
upgrade-go-1.22
branch
from
6889e39 to
6c698eb
Compare
I updated `go.mod` to use 1.22 and ran the following to get these changes: ```sh go mod tidy go mod vendor ``` There are still other parts of the repo that are using an older version of Go (like in the Dockerfiles), but I'll update those in a different PR since this change is already kind of large. Signed-off-by: Charlie Le <charlie_le@apple.com>
Following instructions from https://github.com/golangci/golangci-lint-action Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
CharlieTLe
force-pushed
the
upgrade-go-1.22
branch
from
6c698eb to
df76bcc
Compare
friedrichg
approved these changes
Apr 23, 2024
friedrichg
pushed a commit
that referenced
this pull request
May 9, 2024
* Upgrade Go version to 1.22 in go.mod and workflows I updated `go.mod` to use 1.22 and ran the following to get these changes: ```sh go mod tidy go mod vendor ``` There are still other parts of the repo that are using an older version of Go (like in the Dockerfiles), but I'll update those in a different PR since this change is already kind of large. Signed-off-by: Charlie Le <charlie_le@apple.com> * Update usage golangci Following instructions from https://github.com/golangci/golangci-lint-action Signed-off-by: Charlie Le <charlie_le@apple.com> * Deprecate use of ioutil package Signed-off-by: Charlie Le <charlie_le@apple.com> * Remove unused parameters Signed-off-by: Charlie Le <charlie_le@apple.com> --------- Signed-off-by: Charlie Le <charlie_le@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated
go.modto use 1.22 and ran the following to get these changes:There are still other parts of the repo that are using an older version of Go (like in the Dockerfiles), but I'll update those in a different PR since this change is already kind of large.