Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set tenant id in prom analyse command #31

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Set tenant id in prom analyse command #31

merged 2 commits into from
Apr 24, 2024

Conversation

CharlieTLe
Copy link
Member

@CharlieTLe
Set tenant id in prom analyse command
12c679b 
- refactor roundtripper to be used in query_runner too
- fixes cortexproject#13

Signed-off-by: Charlie Le <charlie_le@apple.com>
@CharlieTLe CharlieTLe requested a review from friedrichg April 21, 2024 02:43
friedrichg
friedrichg reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@friedrichg friedrichg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Looks good, my only suggestions would be:

  • add or modify a test for the bugfix. It's a general suggestion. It always feels wrong when we add features of fix bugs and tests are not touched.
  • adjust the changelog

@CharlieTLe
Update tests, changelog, docs
d2c6ed9 
Signed-off-by: Charlie Le <charlie_le@apple.com>
friedrichg
friedrichg approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@friedrichg friedrichg merged commit 4fdaaf7 into cortexproject:main Apr 24, 2024
4 checks passed
friedrichg pushed a commit that referenced this pull request May 9, 2024
@CharlieTLe @friedrichg
Set tenant id in prom analyse command (#31)
f89c799 
* Set tenant id in prom analyse command

- refactor roundtripper to be used in query_runner too
- fixes #13

Signed-off-by: Charlie Le <charlie_le@apple.com>

* Update tests, changelog, docs

Signed-off-by: Charlie Le <charlie_le@apple.com>

---------

Signed-off-by: Charlie Le <charlie_le@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichg friedrichg friedrichg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending org Id to analyse prometheus command is not supported
2 participants
@CharlieTLe @friedrichg