Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weaveworks common #1339

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

nrjpoddar
Copy link

Fixes: #1279

Neeraj Poddar added 2 commits April 22, 2019 13:12
Signed-off-by: Neeraj Poddar <neeraj@aspenmesh.io>
Signed-off-by: Neeraj Poddar <neeraj@aspenmesh.io>
@nrjpoddar
Copy link
Author

@bboreham PTAL

@bboreham
Copy link
Contributor

Thanks.

In addition to the item linked (Skip logging context cancelled warning msgs - weaveworks/common#151), this PR brings in a number of other changes:

Full list of commits

@nrjpoddar
Copy link
Author

@bboreham should I include this list as part of my commit message?

@nrjpoddar
Copy link
Author

can this be merged? I don't have merge permissions.

@bboreham
Copy link
Contributor

It is awaiting a second review as required by our rules

I don't need you to change anything, although you might take it as a guide to what is useful to know when reviewing a change.

@gouthamve gouthamve merged commit 5be81b0 into cortexproject:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants