Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable privacy app, to conform w/ the new default #1986

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

7heo
Copy link
Contributor

@7heo 7heo commented Oct 1, 2024

The following changes are implemented

Add the privacy app to the default enabled apps. See https://forum.cortezaproject.org/t/privacy-namespace-issue/1911/6.

Changes in the user interface:

Does not redirect to the front page by default when clicking on the "privacy" app.

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@7heo
Copy link
Contributor Author

7heo commented Oct 1, 2024

Given the triviality of changes, I did not bother adding tests or testing the build. I hope this is alright.

Edit: also, I did not find tests for non-API routes for the various webapps, so in case any of the webapps get disabled by mistake, the regression will likely go undetected.

@Fajfa
Copy link
Member

Fajfa commented Oct 2, 2024

Thanks for this, will merge!

@Fajfa Fajfa merged commit ea97ea4 into cortezaproject:2023.9.x Oct 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants