Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace classloader isolation strategy with process isolation strategy #206

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Replace classloader isolation strategy with process isolation strategy #206

merged 2 commits into from
Oct 30, 2023

Conversation

simonhauck
Copy link
Collaborator

@simonhauck simonhauck commented Oct 29, 2023

🚀 Description

Replace the class loader isolations strategy with the process isolation strategy to fix memory leaks in large projects

📄 Motivation and Context

Fix for this issue which is caused by this issue
With the current strategy large projects can not be formatted due to memory leaks.
Fixes #203

🧪 How Has This Been Tested?

Added two new integration tests to verify that the ktfmtCheck and ktfmtFormat tasks work up to 1000 files as expected.

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@simonhauck simonhauck marked this pull request as ready for review October 29, 2023 11:20
@cortinico cortinico enabled auto-merge (squash) October 30, 2023 08:33
@cortinico cortinico merged commit ed473b2 into cortinico:main Oct 30, 2023
4 checks passed
@simonhauck simonhauck deleted the #203-fix-memory-leaks branch October 30, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting can fail depending on the number of input files
2 participants