Make KtfmtCheckTask task cacheable
#265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
approved these changes
Mar 8, 2024
|
Can you also update the changelog @pbielicki ? |
sure - this weekend or just after - I'll ping you |
|
@cortinico done - ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
This change makes
KtfmtCheckTaskcacheable.📄 Motivation and Context
KtfmtCheckTaskshould be cacheable. It does not make sense to check again the same files.🧪 How Has This Been Tested?
I added two tests and removed one.
Here's the Build Scan from my local build: https://scans.gradle.com/s/pgyogose35nba/tests/overview
📦 Types of changes
✅ Checklist