Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task descriptions #342

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Fix task descriptions #342

merged 3 commits into from
Aug 17, 2024

Conversation

jessestricker
Copy link
Contributor

🚀 Description

I've just switched the task descriptions.

📄 Motivation and Context

Fixes #340.

🧪 How Has This Been Tested?

No tests needed, I hope 😅.

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@simonhauck
Copy link
Collaborator

Hehehhe :D
I think we had the same idea: #341

Copy link
Collaborator

@simonhauck simonhauck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you create also a changelog entry similar to this here
https://github.com/cortinico/ktfmt-gradle/pull/341/files
I can approve your PR and merge it.

@jessestricker
Copy link
Contributor Author

The online GitHub editor changed the final newline in the CHANGELOG.md, is that an issue?

@simonhauck
Copy link
Collaborator

The online GitHub editor changed the final newline in the CHANGELOG.md, is that an issue?

Personally, I do not mind, but I am not sure if @cortinico has some opinion about this. Just to be safe, I remove the new line.

CHANGELOG.md Outdated Show resolved Hide resolved
@simonhauck
Copy link
Collaborator

@jessestricker Thanks your Bug report and also the quick PR :) This is really appreciated.

@simonhauck simonhauck merged commit 997a8de into cortinico:main Aug 17, 2024
4 checks passed
@jessestricker jessestricker deleted the patch-1 branch August 17, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task descriptions are incorrect
2 participants