Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reloading doesn't work with functional components #80

Closed
drawveloper opened this issue Mar 21, 2016 · 7 comments
Closed

Hot reloading doesn't work with functional components #80

drawveloper opened this issue Mar 21, 2016 · 7 comments
Labels

Comments

@drawveloper
Copy link
Contributor

Just thought I'd share this here since it took me 2 hours to find out why the functional components weren't hot reloading: gaearon/babel-plugin-react-transform#57

@coryhouse
Copy link
Owner

Good point. It's a known limitation that will likely be resolved soon. Until then, those who care about hot reloading can avoid functional components.

@drawveloper
Copy link
Contributor Author

Yep, might be good adding a comment on the functional components.

On Mon, Mar 21, 2016 at 12:47 PM Cory House notifications@github.com
wrote:

Good point. It's a known limitation that will likely be resolved soon.
Until then, those who care about hot reloading can avoid functional
components.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#80 (comment)

@coryhouse
Copy link
Owner

Added a note to the FAQ.

Thanks for pointing this out @firstdoit

Closing since this isn't a Slingshot specific issue.

@gaearon
Copy link

gaearon commented Apr 18, 2016

React Hot Loader 3 supports functional components without destroying the state.
It supersedes both React Hot Loader and React Transform, and is built on lessons learned from both.
Check it out: gaearon/react-hot-boilerplate#61

@coryhouse
Copy link
Owner

@gaearon - Nice! I'm just about to publish my React and Redux Pluralsight course. I used react-transform-hmre and warned people a change was coming. Any guess when 3.0 will release? Trying to decide if I should wait a few days so the course can use it.

@gaearon
Copy link

gaearon commented Apr 18, 2016

I will keep an eye on 3.0 alpha issues if any are reported and plan to fix them promptly. The documentation is the biggest blocker (gaearon/react-hot-loader#243) because I’m unlikely to have time to work on it until in a month or so. So unless somebody contributes it, I’d say 3.0 can get out as late as June, just because of all the work unrelated to the code that needs to happen.

@coryhouse
Copy link
Owner

@gaearon Excellent - Thanks for the details and the quick reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants