-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot reloading doesn't work with functional components #80
Comments
Good point. It's a known limitation that will likely be resolved soon. Until then, those who care about hot reloading can avoid functional components. |
Yep, might be good adding a comment on the functional components. On Mon, Mar 21, 2016 at 12:47 PM Cory House notifications@github.com
|
Added a note to the FAQ. Thanks for pointing this out @firstdoit Closing since this isn't a Slingshot specific issue. |
React Hot Loader 3 supports functional components without destroying the state. |
@gaearon - Nice! I'm just about to publish my React and Redux Pluralsight course. I used react-transform-hmre and warned people a change was coming. Any guess when 3.0 will release? Trying to decide if I should wait a few days so the course can use it. |
I will keep an eye on 3.0 alpha issues if any are reported and plan to fix them promptly. The documentation is the biggest blocker (gaearon/react-hot-loader#243) because I’m unlikely to have time to work on it until in a month or so. So unless somebody contributes it, I’d say 3.0 can get out as late as June, just because of all the work unrelated to the code that needs to happen. |
@gaearon Excellent - Thanks for the details and the quick reply! |
Just thought I'd share this here since it took me 2 hours to find out why the functional components weren't hot reloading: gaearon/babel-plugin-react-transform#57
The text was updated successfully, but these errors were encountered: