-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pda messaging real #505
Open
dffdff2423
wants to merge
4
commits into
cosmatic-drift-14:master
Choose a base branch
from
dffdff2423:pda-messaging-real
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
pda messaging real #505
dffdff2423
wants to merge
4
commits into
cosmatic-drift-14:master
from
dffdff2423:pda-messaging-real
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: Sprites
Changes to sprites.
Changes: UI
Changes to UI files.
labels
Dec 17, 2024
WHY WAS THIS NOT A THING
dffdff2423
force-pushed
the
pda-messaging-real
branch
from
December 17, 2024 18:36
5268f2a
to
f218be0
Compare
Nairodian
reviewed
Dec 17, 2024
Resources/ServerInfo/Guidebook/ServerRules/GeneralEtiquette/Rule2-3.xml
Outdated
Show resolved
Hide resolved
dffdff2423
force-pushed
the
pda-messaging-real
branch
from
December 17, 2024 19:18
f218be0
to
f9ca2d4
Compare
dffdff2423
force-pushed
the
pda-messaging-real
branch
from
December 17, 2024 19:19
f9ca2d4
to
2fbb24d
Compare
Nairodian
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conceptually and admin wise, fine. Code's not my field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Ports PDA messaging from DeltaV. See the original PR for mechanics.
DeltaV-Station/Delta-v#2362
Permission to port it is contained inside the original PR
Technical details
Moved everything to the CD namespace and added the ability to press enter to send messages.
Changelog
PDA messaging has been ported from DeltaV. You can access it in-game using the nano chat program. We have also relaxed the "no text speach rule" for PDA messages. (credit to MilonPL)