feat: add FoxWallet extension #436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/cosmos-kit/package.json # packages/example/package.json
pyramation
reviewed
Jun 4, 2024
| cosmoshub: { | ||
| rpc: ['https://rpc-cosmoshub.keplr.app'], | ||
| rest: ['https://lcd-cosmoshub.keplr.app'], | ||
| }, |
There was a problem hiding this comment.
hey @ljunb are these your teams' endpoints? The preferred endpoints are meant to be endpoints provided by the wallet. These look like keplr's, do you have a green light from keplr team to use their infra?
There was a problem hiding this comment.
Hello, thanks for the review. We have confirmed that this configuration is not currently used, so we have deleted it.
# Conflicts: # packages/cosmos-kit/src/wallets.ts # packages/docs/pages/_app.tsx # packages/example/pages/_app.tsx
|
Hello, this PR doesn't seem to have made much progress. Do we need to make any changes to the code here? |
# Conflicts: # packages/cosmos-kit/package.json # packages/example/package.json # packages/example/pages/_app.tsx
|
Hey @pyramation, any chance to give this another review 🙏 Looking to be able to use this wallet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.