test cosmjs extension #477
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylinezum
commented
Jun 18, 2024
skylinezum
commented
- Able to run staking.test.ts,
- Modified cosmjs-extension's main-wallet.ts to bypass the window environment
… for deploy and port forward
fix: fix starship
- move config.yaml to project/starship/ - update corresponding paths
- create cosmjs wallet from leap extension
- remove unused lines - remove cosmjs wallet from cosmos-kit
pyramation
reviewed
Jun 18, 2024
wallets/cosmjs-extension/README.md
Outdated
| @@ -0,0 +1,40 @@ | |||
| # @cosmos-kit/leap-extension | |||
There was a problem hiding this comment.
should read cosmjs-extension
pyramation
reviewed
Jun 18, 2024
|
|
||
| async getAccount(chainId: string) { | ||
| // const key = await this.client.getKey(chainId); | ||
| const mnemonic = this.generateMnemonic(); |
There was a problem hiding this comment.
this seems that it would be non-deterministic — shouldn't the client somehow have a reference to the mnemonic? and we create it in the test itself?
pyramation
reviewed
Jun 18, 2024
- clean up readme for cosmjs-extension - allow passsing in an optional mnemonic or let it generate by default.
- .yarn.lock - 'nock'; remove ;
- clean up readme for cosmjs-extension - allow passsing in an optional mnemonic or let it generate by default. - fix merge conflicts
…ch-space/cosmos-kit into testing/starship-steven
skylinezum
commented
Jun 20, 2024
Comment on lines
+53
to
+55
| "starship:deploy": "starship deploy --config ./starship/starship.yaml", | ||
| "starship:ports": "starship start-ports --config ./starship/starship.yaml", | ||
| "starship:teardown": "starship teardown --config ./starship/starship.yaml", |
Comment on lines
+95
to
+96
| "@starship-ci/cli": "1.9.0", | ||
| "starshipjs": "^1.4.0", |
Comment on lines
+7
to
+22
| yarn starship setup | ||
|
|
||
| # sanity check | ||
| yarn starship get-pods | ||
|
|
||
| # deploy starship | ||
| yarn starship deploy | ||
|
|
||
| # wait til STATUS=Running | ||
| yarn starship get-pods | ||
|
|
||
| # port forwarding | ||
| yarn starship start-ports | ||
|
|
||
| # check pids | ||
| yarn starship port-pids |
There was a problem hiding this comment.
replace with yarn starship start
Comment on lines
+36
to
+42
| ```sh | ||
| # stop port forwarding (done by clean() too) | ||
| # yarn starship stop-ports | ||
|
|
||
| # stop ports and delete & remove helm chart | ||
| yarn starship clean | ||
| ``` |
There was a problem hiding this comment.
replace with yarn starship stop
| # stop ports and delete & remove helm chart | ||
| yarn starship clean | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Check latest docs in starship repo
| signer: string, | ||
| data: string | Uint8Array, | ||
| ): Promise<StdSignature> { | ||
| return await this.client.signArbitrary(chainId, signer, data); |
| import Long from 'long'; | ||
|
|
||
| export class CosmjsClient implements WalletClient { | ||
| readonly client: Cosmjs; |
There was a problem hiding this comment.
add comment:
warning: CosmjsClient is for testing only! Mnemonic is gettable.
| prettyName: 'Cosmjs', | ||
| logo: ICON, | ||
| mode: 'extension', | ||
| mobileDisabled: () => !('cosmjs' in window || /CosmjsCosmos/i.test(navigator.userAgent)), |
| prettyName: 'Cosmjs', | ||
| logo: ICON, | ||
| mode: 'extension', | ||
| mobileDisabled: () => !('cosmjs' in window || /CosmjsCosmos/i.test(navigator.userAgent)), |
There was a problem hiding this comment.
@pyramation @theothersideofgod isInstalled maybe add this method here.
Comment on lines
+55
to
+59
| "dependencies": { | ||
| "@cosmos-kit/leap-extension": "^2.9.0", | ||
| "@cosmos-kit/leap-metamask-cosmos-snap": "^0.8.0", | ||
| "@cosmos-kit/leap-mobile": "^2.8.0" | ||
| }, |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.