Make vm serializable #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedawilson
commented
Sep 23, 2022
| @@ -30,6 +30,7 @@ | |||
| "downlevelIteration": true, | |||
| "outDir": "dist", | |||
| "rootDir": "src", | |||
| "skipLibCheck": true, | |||
There was a problem hiding this comment.
See https://www.typescriptlang.org/tsconfig#skipLibCheck for details.
Rather than doing a full check of all d.ts files, TypeScript will type check the code you specifically refer to in your app’s source code.
Otherwise, we get these two errors due to webpack:
node_modules/@types/eslint/index.d.ts:451:42 - error TS2724: '"/Users/lukewilson/git/terra/cosmwasm-vm-js/node_modules/@types/estree/index"' has no exported member named 'ChainExpression'. Did you mean 'Expression'?
451 ChainExpression?: ((node: ESTree.ChainExpression & NodeParentExtension) => void) | undefined;
~~~~~~~~~~~~~~~
node_modules/@types/eslint/index.d.ts:474:43 - error TS2694: Namespace '"/Users/lukewilson/git/terra/cosmwasm-vm-js/node_modules/@types/estree/index"' has no exported member 'ImportExpression'.
474 ImportExpression?: ((node: ESTree.ImportExpression & NodeParentExtension) => void) | undefined;
lukedawilson
commented
Sep 23, 2022
|
|
||
| constructor(backend: IBackend) { | ||
| this.backend = backend; | ||
| this.bech32 = bech32; | ||
| this.eddsa = new eddsa('ed25519'); |
There was a problem hiding this comment.
eddsa is not serialisable, but nor does it (seem to) hold any (mutable) state - its methods appear to be pure functions.
lukedawilson
commented
Sep 23, 2022
| export * from './memory'; | ||
| export * from './backend'; | ||
| export * from './instance'; | ||
| export * from './environment'; | ||
|
|
||
| global.eddsa = () => global._eddsa || (global._eddsa = new eddsa('ed25519')); |
There was a problem hiding this comment.
We want to store this globally (and lazy-initialise it) because constructing it each time is slow - on my year-old macbook, about 500ms.
Kiruse
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.