Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cosmos_sdk again: cosmrs? #113

Closed
tony-iqlusion opened this issue Aug 3, 2021 · 5 comments
Closed

Rename cosmos_sdk again: cosmrs? #113

tony-iqlusion opened this issue Aug 3, 2021 · 5 comments

Comments

@tony-iqlusion
Copy link
Member

After we got the cosmos_sdk crate, I was somewhat disappointed to discover that it's locked into using an underscore, which is somewhat annoying given it doesn't match cosmos-sdk-proto.

Additionally, the cosmos-sdk-rs branding isn't great in many ways: it implements a minute amount of functionality of the actual Go cosmos-sdk. Given that I think it inevitably sets a user up for disappointment when they're looking for a full-blown analog of the upstream Go library.

I've been wondering if a pithier name for a "Cosmos Rust Support Library" might be appropriate. The name I've been batting around in my head is "cosmrs", as in cosmos + rs. I think it also pairs nicely with CosmWasm.

WDYT?

@ethanfrey
Copy link

I like it. It also pairs nicely with CosmJS, which is a client side js lib.

Cosmrs or cosm-rs, both work for me. But the name seems more clear (I was expecting a server side sdk as well)

@adizere
Copy link

adizere commented Aug 3, 2021

Clarifying that the repo is a "Cosmos Rust Support Library" would definitely improve usability and expectations.

@andynog
Copy link

andynog commented Aug 3, 2021

I would rather it to be called cosm-rs to match other Rust projects naming like tendermint-rs and ibc-rs. Also, clarifying that this is a client side library would be important.

Another thing that I think it'd be important for the ecosystem would be to eventually track the client side implementations features so users can understand what is already implemented or not, for example CosmJS currently probably offers the broadest implementation support for modules (bank, auth, etc). This could be useful for other client libraries too like Alan.dart (Dart) for example.

@tony-iqlusion
Copy link
Member Author

tony-iqlusion commented Aug 3, 2021

I would rather it to be called cosm-rs to match other Rust projects naming like tendermint-rs and ibc-rs.

We've previously been tacking -rs onto the name (cosmos-sdk-rs) even though the crate is named cosmos_sdk, in the same way that tendermint-rs is technically the tendermint crate and ibc-rs is technically the ibc crate.

However, in this case I'm proposing actually putting it in the crate name and calling it cosmrs, which is more of a play on changing o -> r.

tony-iqlusion added a commit that referenced this issue Aug 25, 2021
As discussed in #113, this renames "cosmos-sdk-rs" (i.e. the
`cosmos_sdk` crate) to `cosmrs`.
tony-iqlusion added a commit that referenced this issue Aug 25, 2021
As discussed in #113, this renames "cosmos-sdk-rs" (i.e. the
`cosmos_sdk` crate) to `cosmrs`.
@tony-iqlusion
Copy link
Member Author

Renamed to cosmrs in #125, with v0.1.0 released in #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants