cosmrs: cosmos.crypto.multisig.LegacyAminoPubKey support #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for this key type when used as the `public_key` field of `SignerInfo`. To accomodate this, a new `SignerPublicKey` enum was added with variants for a single `PublicKey` or a `LegacyAminoMultisig` key. Decodes a test vector from `cosmoshub-4` (sdk@v0.42.10) Closes #143
tony-iqlusion
commented
Oct 28, 2021
Adds a catch-all variant for unrecognized public key types, which enables parsing transaction types which use public keys with algorithms unknown to `cosmrs` itself.
andynog
reviewed
Oct 28, 2021
andynog
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
I think this overall looks. Had one minor comment on a test. I like the approach with the From and TryFrom to handle the variants of SignerPublicKey and PublicKey.
But I've noticed some changes to other logic that I'm not sure if affects existing code or might be breaking changes. It'd be nice to get another review with more insights on that.
|
Going to go ahead and merge this, then cut a release PR, but I'll leave that open for final review in case anyone has remaining concerns about this PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for this key type when used as the
public_keyfield ofSignerInfo.To accommodate this, a new
SignerPublicKeyenum was added with variants for a singlePublicKeyor aLegacyAminoMultisigkey.Decodes a test vector from
cosmoshub-4(sdk@v0.42.10)Closes #143