Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for uppercase bech32 #444

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Add support for uppercase bech32 #444

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee36ca2
Add support for uppercase bech32
penso Oct 30, 2023
97d924d
Update cosmrs/src/base/account_id.rs
penso Oct 30, 2023
5766d6e
Update cosmrs/src/base/account_id.rs
penso Oct 31, 2023
efd972a
Update cosmrs/src/base/account_id.rs
penso Oct 31, 2023
0c7d30b
Update cosmrs/src/base/account_id.rs
tony-iqlusion Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion cosmrs/src/base/account_id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,12 @@ impl FromStr for AccountId {
type Err = ErrorReport;

fn from_str(s: &str) -> Result<Self> {
let (hrp, bytes) = bech32::decode(s).wrap_err(format!("invalid bech32: '{}'", s))?;
let (hrp, bytes) = if s.starts_with(|c: char| c.is_uppercase()) {
bech32::decode_upper(s)
} else {
bech32::decode(s)
}
.wrap_err(format!("invalid bech32: '{}'", s))?;
Self::new(&hrp, &bytes)
}
}
Expand Down Expand Up @@ -148,6 +153,14 @@ mod tests {
.unwrap();
}

/// See https://en.bitcoin.it/wiki/BIP_0173 -- UPPERCASE is a valid bech32
#[test]
fn with_uppercase() {
"STARS1JUME25TTJLCAQQJZJJQX9HUMVZE3VCC8QF2KWL"
.parse::<AccountId>()
.unwrap();
}

#[test]
fn to_string() {
let account_id = "juno10j9gpw9t4jsz47qgnkvl5n3zlm2fz72k67rxsg"
Expand Down
Loading