Update denom validation #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good find on the upstream Cosmos SDK validation function... do you mind implementing the length check too, and removing the TODO and replacing it with a link to the upstream code? I can do it otherwise |
|
Hmm, letting you do this one if that's ok. Thanks |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at updating cosmrs to handle all valid coin denoms
Context
With token factory modules, denoms are more diverse than before.
Denom validation must follow
Here is the Cosmos sdk coin validation function
https://github.com/cosmos/cosmos-sdk/blob/94338e516d6fd095fdca175b47d87bd9020e7740/types/coin.go#L890