refactor(server)!: remove duplicate bech32 prefix endpoint

This pr removes bech32prefix endpoint from grpc refelction in server. This removes the global usage of bech32 and puts it into auth. Auth already had an endpointt that was used elsewhere.

CHANGELOG.md

@@ -187,6 +187,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (x/auth) [#18351](https://github.com/cosmos/cosmos-sdk/pull/18351) Auth module was moved to its own go.mod `cosmossdk.io/x/auth`
 * (types) [#18372](https://github.com/cosmos/cosmos-sdk/pull/18372) Removed global configuration for coin type and purpose. Setters and getters should be removed and access directly to defined types.
 * (types) [#18695](https://github.com/cosmos/cosmos-sdk/pull/18695) Removed global configuration for txEncoder.
+* (server) [#18909](https://github.com/cosmos/cosmos-sdk/pull/18909) Remove configuration endpoint on grpc reflection endpoint in favour of auth module bech32prefix endpoint already exposed. 
 
 ### CLI Breaking Changes
 

proto/cosmos/base/reflection/v2alpha1/reflection.proto

@@ -15,12 +15,12 @@ message AppDescriptor {
   ChainDescriptor chain = 2;
   // codec provides metadata information regarding codec related types
   CodecDescriptor codec = 3;
-  // configuration provides metadata information regarding the sdk.Config type
-  ConfigurationDescriptor configuration = 4;
   // query_services provides metadata information regarding the available queryable endpoints
   QueryServicesDescriptor query_services = 5;
   // tx provides metadata information regarding how to send transactions to the given application
   TxDescriptor tx = 6;
+
+  reserved 4;
 }
 
 // TxDescriptor describes the accepted transaction type
@@ -99,12 +99,6 @@ message InterfaceAcceptingMessageDescriptor {
   repeated string field_descriptor_names = 2;
 }
 
-// ConfigurationDescriptor contains metadata information on the sdk.Config
-message ConfigurationDescriptor {
-  // bech32_account_address_prefix is the account address prefix
-  string bech32_account_address_prefix = 1;
-}
-
 // MsgDescriptor describes a cosmos-sdk message that can be delivered with a transaction
 message MsgDescriptor {
   // msg_type_url contains the TypeURL of a sdk.Msg.
@@ -127,10 +121,6 @@ service ReflectionService {
   rpc GetCodecDescriptor(GetCodecDescriptorRequest) returns (GetCodecDescriptorResponse) {
     option (google.api.http).get = "/cosmos/base/reflection/v1beta1/app_descriptor/codec";
   }
-  // GetConfigurationDescriptor returns the descriptor for the sdk.Config of the application
-  rpc GetConfigurationDescriptor(GetConfigurationDescriptorRequest) returns (GetConfigurationDescriptorResponse) {
-    option (google.api.http).get = "/cosmos/base/reflection/v1beta1/app_descriptor/configuration";
-  }
   // GetQueryServicesDescriptor returns the available gRPC queryable services of the application
   rpc GetQueryServicesDescriptor(GetQueryServicesDescriptorRequest) returns (GetQueryServicesDescriptorResponse) {
     option (google.api.http).get = "/cosmos/base/reflection/v1beta1/app_descriptor/query_services";
@@ -165,14 +155,6 @@ message GetCodecDescriptorResponse {
   CodecDescriptor codec = 1;
 }
 
-// GetConfigurationDescriptorRequest is the request used for the GetConfigurationDescriptor RPC
-message GetConfigurationDescriptorRequest {}
-// GetConfigurationDescriptorResponse is the response returned by the GetConfigurationDescriptor RPC
-message GetConfigurationDescriptorResponse {
-  // config describes the application's sdk.Config
-  ConfigurationDescriptor config = 1;
-}
-
 // GetQueryServicesDescriptorRequest is the request used for the GetQueryServicesDescriptor RPC
 message GetQueryServicesDescriptorRequest {}
 // GetQueryServicesDescriptorResponse is the response returned by the GetQueryServicesDescriptor RPC

server/grpc/reflection/v2alpha1/reflection.go

@@ -15,7 +15,6 @@ import (
 type Config struct {
 	SigningModes      map[string]int32
 	ChainID           string
-	SdkConfig         *sdk.Config
 	InterfaceRegistry codectypes.InterfaceRegistry
 }
 
@@ -46,10 +45,6 @@ func (r reflectionServiceServer) GetCodecDescriptor(_ context.Context, _ *GetCod
 	return &GetCodecDescriptorResponse{Codec: r.desc.Codec}, nil
 }
 
-func (r reflectionServiceServer) GetConfigurationDescriptor(_ context.Context, _ *GetConfigurationDescriptorRequest) (*GetConfigurationDescriptorResponse, error) {
-	return &GetConfigurationDescriptorResponse{Config: r.desc.Configuration}, nil
-}
-
 func (r reflectionServiceServer) GetQueryServicesDescriptor(_ context.Context, _ *GetQueryServicesDescriptorRequest) (*GetQueryServicesDescriptorResponse, error) {
 	return &GetQueryServicesDescriptorResponse{Queries: r.desc.QueryServices}, nil
 }
@@ -61,10 +56,6 @@ func (r reflectionServiceServer) GetTxDescriptor(_ context.Context, _ *GetTxDesc
 func newReflectionServiceServer(grpcSrv *grpc.Server, conf Config) (reflectionServiceServer, error) {
 	// set chain descriptor
 	chainDescriptor := &ChainDescriptor{Id: conf.ChainID}
-	// set configuration descriptor
-	configurationDescriptor := &ConfigurationDescriptor{
-		Bech32AccountAddressPrefix: conf.SdkConfig.GetBech32AccountAddrPrefix(),
-	}
 	// set codec descriptor
 	codecDescriptor, err := newCodecDescriptor(conf.InterfaceRegistry)
 	if err != nil {
@@ -82,7 +73,6 @@ func newReflectionServiceServer(grpcSrv *grpc.Server, conf Config) (reflectionSe
 		Authn:         authnDescriptor,
 		Chain:         chainDescriptor,
 		Codec:         codecDescriptor,
-		Configuration: configurationDescriptor,
 		QueryServices: queryServiceDescriptor,
 		Tx:            txDescriptor,
 	}