fix test spec

cosmos · Sep 20, 2024 · 62f47d8 · 62f47d8
1 parent 6cfe75f
commit 62f47d8
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 15 deletions.
diff --git a/tests/integration/tx/aminojson/aminojson_test.go b/tests/integration/tx/aminojson/aminojson_test.go
@@ -341,8 +341,8 @@ func TestAminoJSON_LegacyParity(t *testing.T) {
 			dynamicBytes, err := aj.Marshal(fixture.DynamicMessage(t, tc.gogo))
 			require.NoError(t, err)
 
-			fmt.Printf("legacy: %s\n", string(legacyBytes))
-			fmt.Printf("   sut: %s\n", string(dynamicBytes))
+			t.Logf("legacy: %s\n", string(legacyBytes))
+			t.Logf("   sut: %s\n", string(dynamicBytes))
 			if tc.fails {
 				require.NotEqual(t, string(legacyBytes), string(dynamicBytes))
 				return

diff --git a/tests/integration/tx/context_test.go b/tests/integration/tx/context_test.go
@@ -6,6 +6,7 @@ import (
 	"cosmossdk.io/depinject"
 	"cosmossdk.io/log"
 	_ "cosmossdk.io/x/accounts"
+	"cosmossdk.io/x/tx/signing"
 	codectypes "github.com/cosmos/cosmos-sdk/codec/types"
 	"github.com/cosmos/cosmos-sdk/tests/integration/tx/internal"
 	"github.com/cosmos/cosmos-sdk/tests/integration/tx/internal/pulsar/testpb"
@@ -14,6 +15,10 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+func ProvideCustomGetSigner() signing.CustomGetSigner {
+	return internal.TestRepeatedFieldsSigner
+}
+
 func TestDefineCustomGetSigners(t *testing.T) {
 	var interfaceRegistry codectypes.InterfaceRegistry
 	_, err := simtestutil.SetupAtGenesis(
@@ -26,7 +31,7 @@ func TestDefineCustomGetSigners(t *testing.T) {
 				configurator.ConsensusModule(),
 			),
 			depinject.Supply(log.NewNopLogger()),
-			depinject.Provide(internal.ProvideCustomGetSigner),
+			depinject.Provide(ProvideCustomGetSigner),
 		),
 		&interfaceRegistry,
 	)

diff --git a/tests/integration/tx/internal/util.go b/tests/integration/tx/internal/util.go
@@ -29,16 +29,14 @@ import (
 	gogoproto "github.com/cosmos/gogoproto/proto"
 )
 
-func ProvideCustomGetSigner() signing.CustomGetSigner {
-	return signing.CustomGetSigner{
-		MsgType: proto.MessageName(&testpb.TestRepeatedFields{}),
-		Fn: func(msg proto.Message) ([][]byte, error) {
-			testMsg := msg.(*testpb.TestRepeatedFields)
-			// arbitrary logic
-			signer := testMsg.NullableDontOmitempty[1].Value
-			return [][]byte{[]byte(signer)}, nil
-		},
-	}
+var TestRepeatedFieldsSigner = signing.CustomGetSigner{
+	MsgType: proto.MessageName(&testpb.TestRepeatedFields{}),
+	Fn: func(msg proto.Message) ([][]byte, error) {
+		testMsg := msg.(*testpb.TestRepeatedFields)
+		// arbitrary logic
+		signer := testMsg.NullableDontOmitempty[1].Value
+		return [][]byte{[]byte(signer)}, nil
+	},
 }
 
 type noOpAddressCodec struct{}
@@ -71,7 +69,7 @@ func NewSigningFixture(
 	t.Helper()
 	// set up transaction and signing infra
 	addressCodec, valAddressCodec := noOpAddressCodec{}, noOpAddressCodec{}
-	customGetSigners := []signing.CustomGetSigner{ProvideCustomGetSigner()}
+	customGetSigners := []signing.CustomGetSigner{TestRepeatedFieldsSigner}
 	interfaceRegistry, _, err := codec.ProvideInterfaceRegistry(
 		addressCodec,
 		valAddressCodec,

diff --git a/x/auth/migrations/legacytx/stdtx_test.go b/x/auth/migrations/legacytx/stdtx_test.go
@@ -44,7 +44,7 @@ func TestStdSignBytes(t *testing.T) {
 		Amount:   []*basev1beta1.Coin{{Denom: "atom", Amount: "150"}},
 		GasLimit: 100000,
 	}
-	msgStr := fmt.Sprintf(`{"type":"testpb/TestMsg","value":{"decField":"0","signers":["%s"]}}`, addr)
+	msgStr := fmt.Sprintf(`{"type":"testpb/TestMsg","value":{"decField":"0.000000000000000000","signers":["%s"]}}`, addr)
 	tests := []struct {
 		name string
 		args args