allow generation of gentxs with empty memo field (#3478)

cosmos · Feb 2, 2019 · 884ce49 · 884ce49
1 parent 08e62fb
commit 884ce49
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/PENDING.md b/PENDING.md
@@ -51,6 +51,7 @@ IMPROVEMENTS
   * [\#3418](https://github.com/cosmos/cosmos-sdk/issues/3418) Add vesting account
   genesis validation checks to `GaiaValidateGenesisState`.
   * [\#3420](https://github.com/cosmos/cosmos-sdk/issues/3420) Added maximum length to governance proposal descriptions and titles
+  * [\#3424](https://github.com/cosmos/cosmos-sdk/issues/3424) Allow generation of gentxs with empty memo field.
 
 * SDK
   * [\#2986](https://github.com/cosmos/cosmos-sdk/pull/2986) Store Refactor

diff --git a/cmd/gaia/init/gentx.go b/cmd/gaia/init/gentx.go
@@ -61,9 +61,11 @@ following delegation and commission default parameters:
 			if err != nil {
 				return err
 			}
+
 			ip, err := server.ExternalIP()
 			if err != nil {
-				return err
+				fmt.Fprintf(os.Stderr, "couldn't retrieve an external IP, "+
+					"consequently the tx's memo field will be unset: %s", err)
 			}
 
 			genDoc, err := LoadGenesisDoc(cdc, config.GenesisFile())