Merge PR #4831: Prevent community spend proposal from transferring fu…

…nds to a ModuleAcc
cosmos · Aug 2, 2019 · cbc802c · cbc802c
1 parent 9937101
commit cbc802c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/.pending/bugfixes/modules/_prevent-community-s b/.pending/bugfixes/modules/_prevent-community-s
@@ -0,0 +1 @@
+#4831 Prevent community spend proposal from transferring funds to a module account
diff --git a/x/distribution/keeper/proposal_handler.go b/x/distribution/keeper/proposal_handler.go
@@ -9,6 +9,10 @@ import (
 
 // HandleCommunityPoolSpendProposal is a handler for executing a passed community spend proposal
 func HandleCommunityPoolSpendProposal(ctx sdk.Context, k Keeper, p types.CommunityPoolSpendProposal) sdk.Error {
+	if k.blacklistedAddrs[p.Recipient.String()] {
+		return sdk.ErrUnauthorized(fmt.Sprintf("%s is blacklisted from receiving external funds", p.Recipient))
+	}
+
 	err := k.DistributeFromFeePool(ctx, p.Amount, p.Recipient)
 	if err != nil {
 		return err