fix(upgrade): Stop treating inline JSON as a URL

Fix #19686
cosmos · Mar 8, 2024 · cc83347 · cc83347
1 parent 28801fc
commit cc83347
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/x/upgrade/plan/info.go b/x/upgrade/plan/info.go
@@ -54,7 +54,7 @@ func ParseInfo(infoStr string, opts ...ParseOption) (*Info, error) {
 	}
 
 	// If it's a url, download it and treat the result as the real info.
-	if _, err := neturl.Parse(infoStr); err == nil {
+	if _, err := neturl.ParseRequestURI(infoStr); err == nil {
 		if err := ValidateURL(infoStr, parseConfig.EnforceChecksum); err != nil {
 			return nil, err
 		}

diff --git a/x/upgrade/plan/info_test.go b/x/upgrade/plan/info_test.go
@@ -76,6 +76,12 @@ func (s *InfoTestSuite) TestParseInfo() {
 			expectedInfo:    nil,
 			expectedInError: []string{"plan info must not be blank"},
 		},
+		{
+			name:            "empty JSON",
+			infoStrMaker:    makeInfoStrFuncString("{}"),
+			expectedInfo:    &Info{},
+			expectedInError: nil,
+		},
 		{
 			name:            "json binaries is wrong data type",
 			infoStrMaker:    makeInfoStrFuncString(binariesWrongJSON),