chore(client): use command's configured output (backport #22334) (#22337

)

Co-authored-by: Mark Rushakoff <mark.rushakoff@gmail.com>

client/cmd.go

@@ -345,7 +345,7 @@ func GetClientQueryContext(cmd *cobra.Command) (Context, error) {
 // - client.Context field pre-populated & flag not set: uses pre-populated value
 // - client.Context field pre-populated & flag set: uses set flag value
 func GetClientTxContext(cmd *cobra.Command) (Context, error) {
-	ctx := GetClientContextFromCmd(cmd)
+	ctx := GetClientContextFromCmd(cmd).WithOutput(cmd.OutOrStdout())
 	return readTxCommandFlags(ctx, cmd.Flags())
 }
 

client/cmd_test.go

@@ -1,6 +1,7 @@
 package client_test
 
 import (
+	"bytes"
 	"context"
 	"fmt"
 	"testing"
@@ -137,3 +138,28 @@ func TestSetCmdClientContextHandler(t *testing.T) {
 		})
 	}
 }
+
+func TestContext_usesCobraCommandOutput(t *testing.T) {
+	var initCtx client.Context
+
+	cmd := &cobra.Command{
+		PreRunE: func(cmd *cobra.Command, args []string) error {
+			return client.SetCmdClientContextHandler(initCtx, cmd)
+		},
+		RunE: func(cmd *cobra.Command, _ []string) error {
+			cctx, err := client.GetClientTxContext(cmd)
+			if err != nil {
+				return err
+			}
+
+			return cctx.PrintString("hello")
+		},
+	}
+
+	var outBuf bytes.Buffer
+	cmd.SetOutput(&outBuf)
+
+	require.NoError(t, cmd.Execute())
+
+	require.Equal(t, "hello", outBuf.String())
+}