Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: init command genesis file w/o validator filled #124

Closed
greg-szabo opened this issue Jun 20, 2017 · 3 comments
Closed

Enhancement: init command genesis file w/o validator filled #124

greg-szabo opened this issue Jun 20, 2017 · 3 comments

Comments

@greg-szabo
Copy link
Member

The basecoin init command should be able to generate genesis.json files that have the validator part filled (as it is now) or where the validator part is empty. (new enhancement)
This request is also opened for the tendermint app, the the solution should be the same for both. The request number will be pasted below.

Option #1: Keep as is and introduce switch:
basecoin init --not-a-validator (or similar, like --no-validator)

Option #2: Make no-validator the default and optionally fill it:
basecoin init (creates genesis.json with validator not filled basecoin init --validator` (creates genesis.json with validator filled)

I like the second option for two reasons:

  1. It's better if switches add functionality than when they remove functionality.
  2. Since the packaging process packages tendermint with basecoin, basecoin will not be run in-process. The validator part in the basecoin config becomes confusing and unnecessary.
@greg-szabo
Copy link
Member Author

Tendermint request: tendermint/tendermint#542

@ethanfrey
Copy link
Contributor

@ebuchman Do we want this? I think you have a better idea than me of how this should work for end users.

@ebuchman
Copy link
Member

closing so it can be taken up in #324 with new design

alexanderbez added a commit that referenced this issue Apr 5, 2022
)

Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 2.6.1 to 2.9.1.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](goreleaser/goreleaser-action@v2.6.1...v2.9.1)

---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants