Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use sdk.ConsAddressFromBech32 in x/slashing? #12573

Closed
4 tasks
tnasu opened this issue Jul 14, 2022 · 2 comments · Fixed by #12581
Closed
4 tasks

Should use sdk.ConsAddressFromBech32 in x/slashing? #12573

tnasu opened this issue Jul 14, 2022 · 2 comments · Fixed by #12581

Comments

@tnasu
Copy link

tnasu commented Jul 14, 2022

Summary of Bug

The bug is made by #7242

https://github.com/cosmos/cosmos-sdk/pull/7242/files#diff-8d031eaf097128091754bc92b8f4e5ddf2811c40d1662095725f8be23a437593R51

This point use sdk.ConsAddress, but it should use sdk.ConsAddressFromBech32.

signingInfo, found := k.GetValidatorSigningInfo(ctx, sdk.ConsAddress(params.ConsAddress))

Version

d55c1a2

Steps to Reproduce

Just check with your eyes


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

Hey @tnasu that's correct, but there's no point in fixing this. The entire legacy Querier should be removed. @marbar3778 can we make an issue to remove all legacy Queriers?

@tac0turtle
Copy link
Member

#11552

tnasu added a commit to tnasu/finschia-sdk that referenced this issue Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants