Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't include mem stores in commitInfo(app hash) #14916

Closed
yihuang opened this issue Feb 6, 2023 · 1 comment · Fixed by #14931
Closed

don't include mem stores in commitInfo(app hash) #14916

yihuang opened this issue Feb 6, 2023 · 1 comment · Fixed by #14931
Labels
needs-triage Issue that needs to be triaged

Comments

@yihuang
Copy link
Collaborator

yihuang commented Feb 6, 2023 •
edited
Loading

Summary

The mem store (just the "mem_capability" right now) is not ignored in the same way as the transient store (code) in commit, so the dummy commit id is included in app hash, which I guess is not expected.

Problem Definition

Proposal

Skip mem stores from commitInfo.
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Feb 6, 2023
@alexanderbez
Copy link
Contributor

Nice catch.

@alexanderbez alexanderbez mentioned this issue Feb 6, 2023
Merged
19 tasks
@mmsqe mmsqe mentioned this issue Jul 28, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage Issue that needs to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: exclude mem store from commit info cosmos/cosmos-sdk
2 participants
@yihuang @alexanderbez